Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resiliency to columns with missing types in SQL Server scaffolding #25748

Merged
merged 1 commit into from
Aug 28, 2021
Merged

Resiliency to columns with missing types in SQL Server scaffolding #25748

merged 1 commit into from
Aug 28, 2021

Conversation

roji
Copy link
Member

@roji roji commented Aug 27, 2021

  • Load columns even if they have no type, warn and skip.
  • Skip indexes/constraints which reference unknown columns.

Fixes #25729

@roji
Resiliency to columns with missing types in SQL Server scaffolding
1585e7f 
* Load columns even if they have no type, warn and skip.
* Skip indexes/constraints which reference unknown columns.

Fixes #25729
@roji roji requested a review from a team August 27, 2021 13:54
@smitpatel smitpatel mentioned this pull request Aug 27, 2021
Closed
@roji roji merged commit 667d016 into release/6.0 Aug 28, 2021
@roji roji deleted the roji/GhostColumns branch August 28, 2021 20:27
@ajcvickers ajcvickers mentioned this pull request Sep 9, 2021
Closed
@0xced 0xced mentioned this pull request Oct 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL Server scaffolding fails because of columns with no database type
2 participants
@roji @smitpatel